]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
st/password-entry: Fix memory leak
authorFlorian Müllner <fmuellner@gnome.org>
Sat, 21 Dec 2019 03:00:56 +0000 (04:00 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Sat, 21 Dec 2019 03:12:03 +0000 (04:12 +0100)
The peek-password icon is currently created twice, whoops.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/910

src/st/st-password-entry.c

index bbca7a261c59769f68c07d8a6343725d4a0a9d8f..31c1ae68c5fe026ff0ce55c264d643d4c89ad69b 100644 (file)
@@ -164,12 +164,6 @@ st_password_entry_init (StPasswordEntry *entry)
                                            NULL);
   st_entry_set_secondary_icon (ST_ENTRY (entry), priv->peek_password_icon);
 
-  priv->peek_password_icon = g_object_new (ST_TYPE_ICON,
-                                           "style-class", "peek-password",
-                                           "icon-name", "eye-not-looking-symbolic",
-                                           NULL);
-  st_entry_set_secondary_icon (ST_ENTRY (entry), priv->peek_password_icon);
-
   clutter_text = st_entry_get_clutter_text (ST_ENTRY (entry));
   clutter_text_set_password_char (CLUTTER_TEXT (clutter_text), BLACK_CIRCLE);